From d2a49592faca66381303d8e0d63665ae44046def Mon Sep 17 00:00:00 2001 From: Willy Tarreau Date: Mon, 8 Dec 2014 11:52:28 +0100 Subject: BUG/MEDIUM: tcp-check: don't rely on random memory contents If "option tcp-check" is used and no "tcp-check" rule is specified, we only look at rule->action which dereferences the proxy's memory and which can randomly match TCPCHK_ACT_CONNECT or whatever else, causing a check to fail. This bug is the result of an incorrect fix attempted in commit f621bea ("BUG/MINOR: tcpcheck connect wrong behavior"). This fix must be backported into 1.5. --- src/checks.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/checks.c b/src/checks.c index f6fb23d..6a72728 100644 --- a/src/checks.c +++ b/src/checks.c @@ -1442,7 +1442,7 @@ static int connect_conn_chk(struct task *t) set_host_port(&conn->addr.to, check->port); } - if (check->type == PR_O2_TCPCHK_CHK) { + if (check->type == PR_O2_TCPCHK_CHK && !LIST_ISEMPTY(&s->proxy->tcpcheck_rules)) { struct tcpcheck_rule *r = (struct tcpcheck_rule *) s->proxy->tcpcheck_rules.n; /* if first step is a 'connect', then tcpcheck_main must run it */ if (r->action == TCPCHK_ACT_CONNECT) { -- 1.7.12.1